desruisseaux commented on code in PR #11029: URL: https://github.com/apache/maven/pull/11029#discussion_r3500081332
########## api/maven-api-classworlds/src/main/java/org/apache/maven/api/classworlds/ClassRealm.java: ########## @@ -0,0 +1,223 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.maven.api.classworlds; + +import java.io.Closeable; +import java.net.URL; + +import org.apache.maven.api.annotations.Experimental; +import org.apache.maven.api.annotations.Nonnull; +import org.apache.maven.api.annotations.Nullable; + +/** + * A class loading realm that provides isolated class loading with controlled imports and exports. + * <p> + * A ClassRealm represents an isolated class loading environment with its own classpath Review Comment: > JPMS resolves its module graph statically at startup, so it can't replace this. Java Module can load modules dynamically too, with steps like below: ```java Path[] files = ...; // Paths to the JAR files of the plugins and dependencies to load. URL[] urls = ...; // Above paths converted to URLs. ModuleFinder modules = ModuleFinder.of(files); Class<?> core = ...; // Some Maven core class. ClassLoader loader = new URLClassLoader(urls, core.getClassLoader()); ModuleLayer parent = core.getModule().getLayer(); Configuration config = parent.configuration().resolveAndBind(ModuleFinder.of(), modules, getAllModuleNames(modules)); ModuleLayer layer = parent.defineModulesWithOneLoader(config, loader); ``` With the following helper method: ```java /** * Returns the names of all modules that the given finder can see. */ private static Set<String> getAllModuleNames(final ModuleFinder modules) { final var names = new HashSet<String>(); for (ModuleReference ref : modules.findAll()) { names.add(ref.descriptor().name()); } return names; } ``` Then we can discover services (e.g., MOJO implementations) provided by the plugin: ```java for (MyService service : ServiceLoader.load(layer, MyService.class)) { // ... } ``` Does something like that has been tried? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
