elharo opened a new pull request, #399: URL: https://github.com/apache/maven-shared-utils/pull/399
In `CommandLineUtils.call()`, `waitUntilDone()` was called on `inputFeeder`, `outputPumper`, and `errorPumper` sequentially without try-finally (lines 298-303 of the original). If an earlier call threw (e.g., `InterruptedException`), the remaining pumpers were never waited on, leaving their threads potentially running. The commented-out code just above (lines 277-297) shows the original author intended a try-finally chain but never enabled it. **Fix:** Replaced the sequential calls and the dead commented block with a proper try-finally chain ensuring all three pumpers are waited on regardless of exceptions from earlier ones. Fixes https://github.com/apache/maven-shared-utils/issues/398 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
