Hiteshsai007 opened a new pull request, #12417: URL: https://github.com/apache/maven/pull/12417
## [MNG-8432] Inherit properties from imported BOMs ### Description This PR resolves [MNG-8432](https://issues.apache.org/jira/browse/MNG-8432) (also referenced as #10196 on GitHub), which adds the capability to inherit properties from imported BOMs. Previously, when a child project imported a BOM using `<dependencyManagement>` with `<scope>import</scope>`, Maven only extracted and merged the `<dependencyManagement>` sections. The `<properties>` block of the BOM was entirely ignored. This limitation forced users to manually duplicate property definitions (e.g., version placeholders) in their consuming POMs to use them in plugins or standard dependencies. **Changes in this PR:** 1. **Model Loading:** Modified `DefaultModelBuilder.loadBomModel` to fetch and return the complete resolved `Model` of the BOM rather than just the `DependencyManagement` object. 2. **Property Extraction:** Updated `importDependencyManagement` to collect the properties from all imported BOM models and merge them into the consuming model. The consuming model's existing properties take precedence, preventing unwanted overrides. 3. **Re-Interpolation Pass:** Because `importDependencyManagement` runs *after* the initial model interpolation pass (`readEffectiveModel`), added a second pass of `interpolateModel(resultModel, request, this)` immediately after importing the properties. This correctly substitutes BOM properties into the unresolved placeholders (e.g., `<version>${lib.version}</version>`) within the model. ### Checklist - [x] Your pull request addresses just one issue, without pulling in other changes. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request has a meaningful subject line and body. - [x] The core Maven IT suite and unit tests run successfully against this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
