ascheman commented on PR #12385:
URL: https://github.com/apache/maven/pull/12385#issuecomment-4878123394
Thanks for the review, @gnodet! Both points addressed (backport of #12384):
**1. Rethrow path** — added coverage for a `ComponentLookupException` whose
cause is *not* a `NoSuchElementException`: it is now asserted to rethrow as
`LookupException` (rather than be swallowed into an empty `Optional`), for both
`lookupOptional` overloads — `lookupOptionalRethrowsOnNonNoSuchElementCause`
and the `(Class, String)` variant. The matrix is now both overloads × {null →
empty, present → value, NoSuchElement cause → empty, other cause → rethrow} = 8
tests.
**2. Commit reference** — added a `[#12340]` prefix to the commit (this
project tracks via GitHub issues rather than JIRA, so no `MNG-XXXX`).
Force-pushed (`7277c0b`); locally green with full gates
(spotless/checkstyle/rat), 8/8. CI re-running.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
