elharo commented on issue #282: URL: https://github.com/apache/maven-dependency-analyzer/issues/282#issuecomment-4892962803
After further investigation, this issue is not reproducible in practice. Modern javac always uses $ notation in class signatures (e.g., `Lx/y/z$Inner;`) rather than dot notation (`Lx/y/z.Inner;`). ASM's SignatureReader treats the entire `x/y/z$Inner` as a single `visitClassType` call, so `visitInnerClassType` is never invoked for real-world class files. The `visitInnerClassType` override in DefaultSignatureVisitor is effectively dead code — it could never produce incorrect results in practice. The recommended fix is simply to remove the dead override. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
