apoorva-01 commented on issue #1646: URL: https://github.com/apache/maven-dependency-plugin/issues/1646#issuecomment-4911332249
I've got a fix ready for this one (option 2 from your list: build the returned set instead of removing from the input, and let the callers do their own `removeAll`). Regression test fails on `master`, passes with the change, and the `analyze` ITs are still green. Before I put up a PR though, I noticed #1652 is already open on the same method. It touches the empty-excludes return too, and the Javadoc it adds calls the set "mutated in place", so it kind of reads like the mutation is meant to stay. Which is the opposite of what this issue's asking for. So I figured I'd check before stepping on it: do you still want the `Iterator.remove()` gone here (subtraction moved out to the callers), or is the mutate-in-place thing the intended answer and this can just be closed? If you do want it removed, happy to rebase on top of #1652 since they both poke at that same return. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
