gnodet commented on code in PR #12430:
URL: https://github.com/apache/maven/pull/12430#discussion_r3541640614
##########
impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/mvnup/goals/PluginUpgradeStrategy.java:
##########
@@ -874,6 +894,139 @@ private record PluginAnalysis(Set<String>
needsManagement, Set<String> needsDire
private record PluginAnalysisResults(
Map<Path, Set<String>> pluginsNeedingManagement, Map<Path,
Set<String>> pluginsNeedingDirectOverride) {}
+ /**
+ * Checks if the given plugin is a Quarkus Maven plugin.
+ */
+ private boolean isQuarkusPlugin(String groupId, String artifactId) {
+ return "quarkus-maven-plugin".equals(artifactId)
+ && ("io.quarkus".equals(groupId) ||
"io.quarkus.platform".equals(groupId));
+ }
+
+ /**
+ * Checks if a property is used as the version of a Quarkus BOM in
dependencyManagement.
+ * Quarkus BOMs are identified by having groupId io.quarkus or
io.quarkus.platform,
+ * type "pom", and scope "import".
+ */
+ private boolean isPropertyUsedByQuarkusBom(Document pomDocument, String
propertyName) {
+ Element root = pomDocument.root();
+ String propertyRef = "${" + propertyName + "}";
+
+ Element depManagement =
root.childElement(DEPENDENCY_MANAGEMENT).orElse(null);
+ if (depManagement == null) {
+ return false;
+ }
+ Element dependencies =
depManagement.childElement(DEPENDENCIES).orElse(null);
+ if (dependencies == null) {
+ return false;
+ }
+
+ return dependencies.childElements(DEPENDENCY).anyMatch(dep -> {
+ String groupId = getChildText(dep, GROUP_ID);
+ String version = getChildText(dep, VERSION);
+ String type = getChildText(dep, "type");
+ String scope = getChildText(dep, "scope");
+ return ("io.quarkus".equals(groupId) ||
"io.quarkus.platform".equals(groupId))
+ && "pom".equals(type)
+ && "import".equals(scope)
+ && propertyRef.equals(version);
+ });
+ }
+
+ /**
+ * Decouples the Quarkus plugin version from a shared BOM property.
+ * Introduces a new property for the plugin version and updates the
plugin's version element,
+ * leaving the BOM property unchanged.
+ */
+ private boolean decoupleQuarkusPluginVersion(
+ Document pomDocument,
+ Element pluginElement,
+ Element versionElement,
+ String sharedPropertyName,
+ PluginUpgradeInfo upgrade,
+ String sectionName,
+ UpgradeContext context) {
Review Comment:
The method signature is actually:
```java
private boolean decoupleQuarkusPluginVersion(
Document pomDocument,
Element versionElement,
String sharedPropertyName,
PluginUpgradeInfo upgrade,
String sectionName,
UpgradeContext context)
```
There is no `pluginElement` parameter — the parameter at that position is
`versionElement`, and it IS used at line 983:
`editor.setTextContent(versionElement, "${" + newPropertyName + "}")`. All
parameters are used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
