gnodet commented on PR #12443: URL: https://github.com/apache/maven/pull/12443#issuecomment-4913988562
**Note:** This PR is a workaround for a missing API in DomTrip. The `Editor` class handles whitespace automatically for element insertion (`insertElementBefore/After`) and comment appending (`addComment`), but has no positional comment insertion method (`insertCommentBefore/After`). This forced mvnup to use the raw `ContainerNode.insertChildBefore` API which doesn't handle `precedingWhitespace`. Filed upstream: maveniverse/domtrip#254 Once DomTrip adds `Editor.insertCommentBefore()`, the manual `precedingWhitespace()` calls here should be replaced with the Editor API. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
