jmestwa-coder commented on code in PR #12410:
URL: https://github.com/apache/maven/pull/12410#discussion_r3546104147
##########
compat/maven-model-builder/src/main/java/org/apache/maven/model/validation/DefaultModelValidator.java:
##########
@@ -1160,6 +1163,15 @@ private boolean isValidId(String id) {
return true;
}
+ /**
+ * An id or version made up only of {@code .} or {@code ..} is a
filesystem path-traversal segment. The dotted
Review Comment:
fair point, I don't have evidence that `.` or `..` are illegal names as
such. the actual problem is the default local repository layout using
artifactId/version verbatim as directory names, which turns these values into
literal `.`/`..` path segments. reworded the javadoc in both validators to say
the rejection is due to that mapping, not the names themselves.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
