kwin commented on code in PR #1949:
URL: https://github.com/apache/maven-resolver/pull/1949#discussion_r3553146127
##########
maven-resolver-api/src/main/java/org/eclipse/aether/ConfigurationProperties.java:
##########
@@ -514,6 +514,39 @@ public final class ConfigurationProperties {
*/
public static final String HTTPS_SECURITY_MODE_INSECURE = "insecure";
+ public enum HttpVersion {
+ /**
+ * The default HTTP version supported by the respective transporter
(the most recent stable one, usually HTTP/2)
+ */
+ DEFAULT,
+ HTTP_1_1,
+ HTTP_2,
+ HTTP_3,
+ /**
+ * The maximum HTTP version supported by the respective transporter
(may be unstable).
+ */
+ MAXIMUM;
+ }
+
+ /**
+ * The maximum and preferred HTTP version. It transparently falls back to
lower version if remote server does not support it.
+ * Value must be a {@link HttpVersion} enum value or its String
representation. Default is {@link #DEFAULT_HTTP_VERSION}.
+ *
+ * @configurationSource {@link
RepositorySystemSession#getConfigProperties()}
+ * @configurationType {@link ConfigurationProperties.HttpVersion}
+ * @configurationDefaultValue {@link #DEFAULT_HTTP_VERSION}
Review Comment:
@cstamas This constant cannot be extracted with
https://github.com/apache/maven-resolver/blob/95044877bff86dec0ae1b03f7e1ec05b3353cfe9/maven-resolver-tools/src/main/java/org/eclipse/aether/tools/CollectConfiguration.java#L429.
Any idea how to fix this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
