gnodet commented on PR #12454: URL: https://github.com/apache/maven/pull/12454#issuecomment-4930458898
Addressed the review feedback in cbdee27c39: 1. **DeduplicateDependenciesStrategy Javadoc** — Clarified that last-wins is an intentional choice (preserves the most recently added declaration), not a claim to match Maven 3's first-wins dependency resolution. Also noted that last-wins *does* match Maven 3's plugin configuration merging behavior. 2. **CommonsCliUpgradeOptions parse() retry loop** — Acknowledged; no change needed since behavior degrades gracefully to an error. 3. **EnforcerVersionRangeStrategy regex scope** — Updated the Javadoc to document that the regex intentionally matches any `4.x` upper bound (e.g., `4.1`, `4.2.1`) since all such bounds should be widened. 4. **ResourceFilteringStrategy BINARY_EXTENSIONS** — Added 10 missing extensions (`png`, `jpg`, `jpeg`, `gif`, `bmp`, `tiff`, `mp3`, `mp4`, `p12`, `pfx`) and softened the wording from "comprehensive" to "common" in both the class Javadoc and the field Javadoc. 5. **RepositoryHttpsUpgradeStrategy LinkedHashMap comment** — Fixed the misleading comment about prefix length ordering. Now correctly states the purpose is predictable insertion-order iteration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
