gnodet opened a new pull request, #12481: URL: https://github.com/apache/maven/pull/12481
## Summary Companion PR to [apache/maven-resolver#1957](https://github.com/apache/maven-resolver/pull/1957), which adds re-entrancy detection to `DefaultRepositorySystem`. With the resolver now skipping validation on re-entrant calls, the consumer-side workarounds that filtered dependencies with uninterpolated `${…}` expressions are no longer needed. **Removed workarounds** (all purely defensive against `MavenValidator` rejection on re-entry): - `DefaultArtifactDescriptorReader`: dependency and managed dependency filtering in `populateResult()` and `filterUninterpolated()` - `ArtifactDescriptorReaderDelegate` (compat): dependency and managed dependency filtering in `populateResult()` - `DefaultProjectDependenciesResolver`: managed dependency placeholder check before `collectDependencies()` - `DefaultDependencyResolver`: `enhanceCollectionError()` for "Invalid Collect Request" with unresolved expressions (error path no longer reachable) **Kept**: Repository filtering (URLs with `${…}` are genuinely invalid — you can't connect to them). This is a **net deletion** of ~116 lines of workaround code across 4 files. ## Context These workarounds were introduced across several PRs (#12049, #12084, #12204, #12305) to work around the fact that Maven 4's `MavenValidator` rejected artifacts with uninterpolated expressions during re-entrant `RepositorySystem` calls (model builder → model resolver → `RepositorySystem` chain). The resolver fix addresses this at the source by detecting re-entrancy via `RequestTrace` ancestry and skipping validation on inner calls. ## Test plan - [x] `mvn test -pl compat/maven-resolver-provider` — all tests pass - [x] `mvn test -pl impl/maven-impl` — all tests pass - [x] `mvn test -pl impl/maven-core` — all tests pass - [ ] Full CI verification 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
