gnodet commented on PR #1714: URL: https://github.com/apache/maven-resolver/pull/1714#issuecomment-4961026836
Thanks for the quick fix, @elharo! The HTML anchor tag and the spacing are both fixed now. 👍 The remaining question from the original review is the link target — `https://maven.apache.org/pom.html#Version_Order_Specification` documents `maven-artifact`'s `ComparableVersion`, while this package implements `GenericVersion` in `maven-resolver`. If the two specs are equivalent, a brief note in the Javadoc saying so would help readers; if they diverge, the link may be misleading. I'll leave that call to the maintainers. --- *🤖 This follow-up was generated by [ForgeBot](https://github.com/gnodet/forgebot-skills). Reviewing new commits on a previously reviewed PR.* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
