ascheman commented on PR #585: URL: https://github.com/apache/maven-parent/pull/585#issuecomment-5000689792
**Approve** — nice, this fixes the root cause rather than papering over it. The real problem in #578 was that `-s .github/settings.xml` *replaced* the ASF-managed `settings.xml`, dropping the deploy server credentials → "missing authorization for deployment". Moving the staging repo into a POM profile lets the default settings (with deploy auth) apply again, and activating it via `.mvn/maven.config` means it reaches every `mvn` invocation — including the wrapper bootstrap that a `-s` arg is easy to miss. `use-apache-staging` mirrors `use-apache-snapshots` 1:1 (symmetric: releases on / snapshots off), and the cleanup is complete — no leftover references to the deleted `settings.xml`. One thought: since this profile lives in the parent POM, downstream repos can now activate `-Dapache.staging` during simultaneous parent votes instead of carrying their own `settings.xml`. Might be worth a line in the docs/issue. (Non-binding review — not a PMC member.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
