desruisseaux commented on PR #3392: URL: https://github.com/apache/maven-surefire/pull/3392#issuecomment-5015556575
Thanks for doing that! I will look closely at the pull request. In the meantime, below is an observation based on the description only. It does not necessarily need an action in this pull request, maybe it is okay to process in steps and address the following point in future pull requests. > `--add-reads` / `--add-modules` lines from the handoff file are intentionally skipped (both one-line and two-line argfile form): they may reference named modules that surefire places on the classpath rather than the module path; surefire keeps generating `--add-reads <module>=ALL-UNNAMED` and `--add-modules ALL-MODULE-PATH` itself, plus `--add-opens` for test packages I think that it would be nice if we could remove all `--add-reads` and `--add-modules` options added by Surefire when a `module-info-patch.args` file is present (these options would still be added automatically as a fallback when `module-info-patch.args` is not present). The intend is: * give more control to the developer (via `module-info-patch.maven`), * ensure that the tests are executed with the same options as the compilation, * make debugging easier by giving the guarantee to the developers that what they see in `module-info-patch.args` is what has been used. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
