elharo commented on code in PR #561:
URL: https://github.com/apache/maven-jar-plugin/pull/561#discussion_r3610933099
##########
src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java:
##########
@@ -288,8 +288,7 @@ public Path createArchive() throws MojoException {
archiver.createArchive(session, project, archive);
return jarFile;
- } catch (Exception e) {
- // TODO: improve error handling
+ } catch (MavenArchiverException e) {
Review Comment:
ArchiverException needs to be caught too. Just because it can propagate does
not mean it should propagate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
