elharo opened a new issue, #140:
URL: https://github.com/apache/maven-shared-jar/issues/140
In `ImportVisitor.java:39`:
```java
private static final Pattern VALID_UTF8_PATTERN =
Pattern.compile("^[\\\\(\\\\)\\\\[A-Za-z0-9;/]+$");
```
The regex does not include `$` (dollar sign). Inner class references
discovered via the UTF-8 constant pool (e.g.,
`org/apache/tools/ant/XmlLogger$TimedElement`) will be filtered out and lost.
The `visitConstantClass` path does not use this filter, so some inner classes
may still be found, but the UTF-8 path misses them. This affects completeness
of import analysis.
**Fix**: Add `$` to the character class:
`"^[\\\\(\\\\)\\\\[A-Za-z0-9;$;/]+$"`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
