gnodet commented on PR #1983: URL: https://github.com/apache/maven-resolver/pull/1983#issuecomment-5024278434
Thanks for the follow-up commit, @kwin — the "Don't skip field without default values" fix directly addresses the behavioral regression I flagged in my review. Verified: `processResolverField` no longer has the early return on null `defValue`, and instead flows through `nvl(defValue, "")` — matching the master branch behavior. Fields like `ClasspathTransporterFactory.CONFIG_PROP_CLASSPATH_MANAGER`, `DefaultOfflineController`'s three keys, and `GnupgConfigurationKeys.GPGCONF_*` will now be correctly included in the generated properties with empty default values, as before. The rest of the changes (continue-on-error pattern with `DocTreePathAwareRuntimeException`, precise `DocTreePath` locations, updated tests) look solid. CI is running on the new commit — will check back when it completes. _This comment was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying._ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
