Copilot commented on code in PR #309: URL: https://github.com/apache/maven-source-plugin/pull/309#discussion_r3618030652
########## src/site/site.xml: ########## @@ -21,6 +21,11 @@ under the License. <site xmlns="http://maven.apache.org/SITE/2.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/SITE/2.0.0 https://maven.apache.org/xsd/site-2.0.0.xsd";> + <skin> + <groupId>org.apache.maven.skins</groupId> + <artifactId>maven-fluido-skin</artifactId> + <version>2.1.0</version> + </skin> <body> Review Comment: This PR is described as fixing Maven 4 IT failures (#261), but this change introduces a Maven Site skin/version update that appears unrelated to the stated problem. Please either explain in the PR description why the site skin change is needed, or move it to a separate PR to keep this fix focused. ########## src/it/reproducible/invoker.properties: ########## @@ -15,4 +15,4 @@ # specific language governing permissions and limitations # under the License. -invoker.goals=remote-resources:process source:jar deploy:deploy +invoker.goals=remote-resources:process jar:jar source:jar deploy:deploy Review Comment: The PR description lists only the invoker mavenOpts change and the maven-deploy-plugin version bump, but this IT also changes the invoked goals (adds `jar:jar`). Please document why this additional goal is required for Maven 4 (or revert it if it’s not needed), so reviewers can evaluate its impact on the reproducibility IT. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
