ascheman commented on code in PR #1086:
URL:
https://github.com/apache/maven-compiler-plugin/pull/1086#discussion_r3619782651
##########
src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java:
##########
@@ -649,6 +649,16 @@ final Charset charset() {
* then the default value is same as above with the addition of {@code
"rebuild-on-add,rebuild-on-change"}.
* It means that a full rebuild will be done if any kind of change is
detected.</p>
*
+ * <p>Whether an annotation processor is considered present depends on the
Java version when {@link #proc}
Review Comment:
Done in f84903d — reflowed the paragraph so each line breaks at a sentence
or comma-delimited clause, and `is unset,` now sits with its clause on the
previous line. Agreed on the cleaner diffs, thanks.
##########
src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java:
##########
@@ -649,6 +649,16 @@ final Charset charset() {
* then the default value is same as above with the addition of {@code
"rebuild-on-add,rebuild-on-change"}.
* It means that a full rebuild will be done if any kind of change is
detected.</p>
*
+ * <p>Whether an annotation processor is considered present depends on the
Java version when {@link #proc}
+ * is unset, because {@code javac} enables annotation processing by
default before Java 23
+ * ({@code -proc:full}) but disables it since Java 23 ({@code
-proc:none} unless a processor is
+ * configured). Consequently, on Java versions prior to 23 the
plugin conservatively assumes that
Review Comment:
No, we do not — removed them in f84903d, plain spaces now. They were
over-cautious on my part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
