elharo commented on code in PR #2000:
URL: https://github.com/apache/maven-resolver/pull/2000#discussion_r3621291749
##########
maven-resolver-impl/src/test/java/org/eclipse/aether/internal/impl/DefaultArtifactResolverTest.java:
##########
@@ -802,7 +802,7 @@ public LocalArtifactResult find(RepositorySystemSession
session, LocalArtifactRe
try {
result.setFile(TestFileUtils.createTempFile(""));
} catch (IOException e) {
- e.printStackTrace();
Review Comment:
ditto for this and following cases
##########
maven-resolver-impl/src/test/java/org/eclipse/aether/internal/impl/DefaultArtifactResolverTest.java:
##########
@@ -737,7 +737,7 @@ public LocalArtifactResult find(RepositorySystemSession
session, LocalArtifactRe
try {
result.setFile(TestFileUtils.createTempFile(""));
} catch (IOException e) {
Review Comment:
This exception doesn't need to be caught or wrapped. Just let it bubble up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
