ascheman commented on PR #281: URL: https://github.com/apache/maven-source-plugin/pull/281#issuecomment-5034671876
Hi @hboutemy — a heads-up that this PR has drifted out of sync with master. Its merge-base is from **April 2024** and it hasn't been rebased since, so the diff adds `maven4-enabled: true` on top of a workflow state that no longer reflects master. Meanwhile master has been building on Maven 4 **by default** since Aug 2025 — the workflow now carries `maven4-build: true` + `maven4-version: '4.0.0-beta-3'` (commits *"(ci) switch to default Maven 4"*, Aug 2025, and *"Sync Maven in CI with project"*, Nov 2025). That's why this shows as conflicting. Beyond the conflict, `maven4-enabled: true` may not be the right fit here. In the shared workflow it *adds* the Maven 4 version to the existing Maven 3 matrix (build on both), whereas `maven4-build: true` builds Maven-4-only. Since this plugin's master moved to the Maven 4 API (#19, [MSOURCES-149] — e.g. `ProjectManager.getCompileSourceRoots(...)`, which doesn't exist in Maven 3), it can't run under Maven 3, so `maven4-enabled` would add Maven-3 matrix cells that can't pass. The current `maven4-build: true` looks correct for an M4-only plugin. So this PR looks superseded and could probably be closed. The actual Maven 4 work still pending is bumping the pinned `4.0.0-beta-3` to a current release and following the API changes since beta-3 — that's #268, which is (rightly) waiting for RC-6. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
