joshiste opened a new pull request, #3397: URL: https://github.com/apache/maven-surefire/pull/3397
Fixes #3396 ### What Make `runOrder=balanced` size its class distribution by the real concurrency — `forkCount × threadCount` — instead of `threadCount` alone. With `forkCount>1` and no `parallel=classes`, `threadCount` is `1`, so balanced previously degraded to a plain slowest-first list and ignored the forks actually consuming tests. ### How - New `forkcount` provider property (`ProviderParameterNames.FORKCOUNT_PROP`), propagated from the mojo to the provider, mirroring the existing `threadcount`. - `BaseProviderFactory.getRunOrderCalculator()` uses `threadCount × forkCount` as the bin-packing width; `getForkCount()` defaults/clamps symmetrically with `getThreadCount()`. - `DefaultRunOrderCalculator` field renamed `threadCount` → `distributedParallelism` to match the wider meaning. - Docs updated in `SurefireMojo`/`IntegrationTestMojo`; the outdated "only relevant with parallel=classes" note removed. ### Tests - Unit: `BaseProviderFactoryTest` covering the width = `threadCount × forkCount`, default, and clamp cases. - IT: `RunOrderIT` (+`RunOrderParallelForksIT`) exercise `balanced` with `forkCount>1` (both reuse modes) and the `forkCount=0` clamp. --- - [x] Each commit in the pull request has a meaningful subject line and body. - [x] Pull request description is detailed enough to understand what it does, how, and why. - [x] Ran `mvn clean install` on the affected modules; basic checks pass. - [x] Ran the relevant integration tests (`mvn -Prun-its ... -Dit.test=RunOrderIT,RunOrderParallelForksIT`) successfully. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
