elharo commented on code in PR #179:
URL:
https://github.com/apache/maven-toolchains-plugin/pull/179#discussion_r3631152722
##########
src/test/java/org/apache/maven/plugins/toolchain/jdk/ToolchainDiscovererTest.java:
##########
@@ -51,4 +56,87 @@ void testDiscovery() {
assertTrue(persistedToolchains.getToolchains().stream()
.anyMatch(tc -> tc.getProvides().containsKey(CURRENT)));
}
+
+ @Test
+ void testVersionComparatorSimple() {
+ ToolchainDiscoverer discoverer = new ToolchainDiscoverer();
+
+ List<ToolchainModel> list = new ArrayList<>();
+ list.add(toolchain("8"));
+ list.add(toolchain("17"));
+ list.add(toolchain("11"));
+
+ list.sort(discoverer.version());
+
+ assertEquals("17", list.get(0).getProvides().getProperty("version"));
+ assertEquals("11", list.get(1).getProvides().getProperty("version"));
+ assertEquals("8", list.get(2).getProvides().getProperty("version"));
+ }
+
+ @Test
+ void testVersionComparatorMultiPart() {
+ ToolchainDiscoverer discoverer = new ToolchainDiscoverer();
+
+ List<ToolchainModel> list = new ArrayList<>();
+ list.add(toolchain("11.0.1"));
+ list.add(toolchain("11.0.31"));
+ list.add(toolchain("17.0.1"));
+ list.add(toolchain("1.8"));
+
+ list.sort(discoverer.version());
+
+ assertEquals("17.0.1",
list.get(0).getProvides().getProperty("version"));
+ assertEquals("11.0.31",
list.get(1).getProvides().getProperty("version"));
+ assertEquals("11.0.1",
list.get(2).getProvides().getProperty("version"));
+ assertEquals("1.8", list.get(3).getProvides().getProperty("version"));
+ }
+
+ @Test
+ void testVersionComparatorMultiDigitSegments() {
+ ToolchainDiscoverer discoverer = new ToolchainDiscoverer();
+
+ List<ToolchainModel> list = new ArrayList<>();
+ list.add(toolchain("17.0.2"));
+ list.add(toolchain("17.0.10"));
+
+ list.sort(discoverer.version());
+
+ assertEquals("17.0.10",
list.get(0).getProvides().getProperty("version"));
+ assertEquals("17.0.2",
list.get(1).getProvides().getProperty("version"));
+ }
Review Comment:
@copilot done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
