ascheman commented on PR #12478: URL: https://github.com/apache/maven/pull/12478#issuecomment-5061282185
Thanks @gnodet — glad the variant was useful, and the implementation looks spot-on. `GenericCachingTestRequestCache` is the right call for accepting a non-`TestRequest` key type, and mutating the trace data mid-batch in both suppliers reproduces exactly the equals-based-map contention that #12472 was about. Keeping the identity-stable test as a complement makes sense too — it guards the concurrent path even though it doesn't bite the specific regression. This now genuinely guards #12472; nothing further from my side. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
