elharo commented on code in PR #2012:
URL: https://github.com/apache/maven-resolver/pull/2012#discussion_r3641828114
##########
maven-resolver-util/src/main/java/org/eclipse/aether/util/concurrency/SmartExecutor.java:
##########
@@ -176,6 +176,7 @@ public void submit(Runnable runnable) {
}
} catch (InterruptedException e) {
Thread.currentThread().interrupt();
+ throw new RuntimeException(e);
Review Comment:
Throwing a raw RuntimeException is an antipattern. Is there a subclass of
RuntimeException we could throw instead?
Whatever exception we throw should be documented in javadoc for this method.
Is the exception handled upstream or is that something we also need to do?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
