Copilot commented on code in PR #633:
URL: https://github.com/apache/maven-war-plugin/pull/633#discussion_r3645040493
##########
src/site/apt/usage.apt.vm:
##########
@@ -129,7 +129,7 @@ documentedproject-1.0-SNAPSHOT.war
*Invocation of <<<war:exploded>>> goal
- To speed up testing during the developement phase, <<<war:explode>>> can be
used to generate the WAR in exploded
+ To speed up testing during the development phase, <<<war:explode>>> can be
used to generate the WAR in exploded
Review Comment:
This paragraph refers to the non-existent goal `war:explode`, but the
section title and the example command use `war:exploded` (the actual Mojo
name). This is a factual inconsistency that can mislead readers.
##########
src/site/apt/index.apt.vm:
##########
@@ -39,10 +39,10 @@ ${project.name}
It builds a WAR file.
* {{{./exploded-mojo.html}war:exploded}} is generally used to speed up
- testing during the developement phase by creating an exploded webapp
+ testing during the development phase by creating an exploded webapp
in a specified directory.
- * {{{./inplace-mojo.html}war:inplace}} another variation of <<<war:explode>>>
+ * {{{./inplace-mojo.html}war:inplace}} another variation of
<<<war:exploded>>>
Review Comment:
This bullet is missing a verb ("is"), which makes it grammatically
inconsistent with the surrounding goal descriptions (e.g., "war:war is…",
"war:exploded is…").
##########
src/site/apt/examples/rapid-testing-jetty6-plugin.apt:
##########
@@ -72,4 +72,4 @@ Rapid Testing Using the Jetty Plugin
The command will block with Jetty listening on port 8080.
- Check the {{{http://docs.codehaus.org/display/JETTY/Maven+Jetty+Plugin}Jetty
Plugin documentation}} for more details.
+ Check the
{{{https://jetty.org/docs/jetty/12/programming-guide/maven-jetty/jetty-maven-plugin.html}Jetty
Plugin documentation}} for more details.
Review Comment:
The updated link points to Jetty 12 Maven plugin docs, but this example
configures the legacy Jetty 6 plugin
(`org.mortbay.jetty:maven-jetty-plugin:6.1.10`). Linking to Jetty 12 docs is
likely to confuse readers because configuration and coordinates differ.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
