Copilot commented on code in PR #154:
URL:
https://github.com/apache/maven-jarsigner-plugin/pull/154#discussion_r3645079268
##########
src/site/apt/usage.apt.vm:
##########
@@ -126,4 +126,4 @@ mvn ... -Djarsigner.skip=true
* How to use encrypted password
- Since version 1.3, you can pass to the plugin some password encrypted by the
maven encryption mechanism.
+ Since version 1.3, you can pass passwords encrypted by the Maven encryption
mechanism to the plugin.
Review Comment:
The section title is singular ("encrypted password"), but the following
sentence (updated in this PR) now refers to "passwords". Consider pluralizing
the header for consistency (it also matches the earlier discussion of
encrypting keypass/storepass).
##########
src/site/fml/faq.fml:
##########
@@ -58,13 +58,13 @@ under the License.
</answer>
</faq>
<faq id="sign_and_assembly">
- <question>Why if I want to sign an artifact and then assembly there is
some problem under windows?</question>
+ <question>Why is there a problem on Windows when I sign an artifact
and then run the assembly plugin?</question>
<answer>
<p>
To fix the problem, just move the assembly execution so it comes
<strong>after</strong> the jarsigner execution in the pom.
Review Comment:
Minor capitalization: in Maven docs this is typically referred to as the
"POM" (acronym). Elsewhere in the site docs you already use "POM" (e.g.,
sign-and-verify-project.apt.vm:69).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
