gnodet commented on code in PR #10906:
URL: https://github.com/apache/maven/pull/10906#discussion_r3646716315
##########
impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/LookupInvoker.java:
##########
@@ -918,6 +931,29 @@ protected int calculateDegreeOfConcurrency(String
threadConfiguration) {
+ "'. Supported are int and float values ending with C.");
}
}
+ // Helper method to normalize MSYS-style paths on Windows
+ private String normalizeMsysPath(String path, C context) {
Review Comment:
Bug: This converts ANY path starting with `/` to a Windows drive path, not
just MSYS drive-letter paths. For example, `/tmp/repo` would produce
`T:mp\repo`.
The method uses `path.substring(1, 2)` without verifying that position 2 is
`/`. `MavenCli.java` correctly uses the regex `^/([a-zA-Z])/(.*)$` which
requires exactly a single letter between two slashes. Consider reusing the same
regex approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
