wilx opened a new pull request, #1093: URL: https://github.com/apache/maven-compiler-plugin/pull/1093
## Summary - Include existing output directories for earlier MR-JAR releases in the `--patch-module` path when the current compilation contains `module-info.java`. - Reuse the same ordered output-directory list for the compiler class path and module patch path. - Add an integration test covering release 8 base classes, a release 9 layer, and a modular release 11 layer that references a release 9 class. ## Motivation The plugin already added earlier MR-JAR output directories to the class path. Once `module-info.java` is present, however, `javac` resolves the sources as a named module and the class path alone does not make those earlier classes part of that module. The existing `--patch-module` option only contained the base output directory. The patch path now contains each existing earlier release directory in descending order, followed by the base output directory. This matches MR-JAR shadowing order and lets the modular execution see the output of earlier executions. Fixes https://github.com/apache/maven-compiler-plugin/issues/579 ## Testing - `JAVA_HOME=/opt/jdks/latest-17 /opt/maven/latest/bin/mvn clean verify` - `JAVA_HOME=/opt/jdks/latest-17 /opt/maven/latest/bin/mvn -Prun-its -Dinvoker.test=MCOMPILER-374_mrjar clean verify` - `JAVA_HOME=/opt/jdks/latest-17 /opt/maven/latest/bin/mvn -Prun-its -Dinvoker.test=MCOMPILER-373_mrjar clean verify` Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MCOMPILER) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[MCOMPILER-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MCOMPILER-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
