gnodet commented on code in PR #12577: URL: https://github.com/apache/maven/pull/12577#discussion_r3669019135
########## impl/maven-core/src/main/java/org/apache/maven/plugin/internal/PluginDescriptorRequirementsValidator.java: ########## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.maven.plugin.internal; + +import javax.inject.Inject; +import javax.inject.Named; +import javax.inject.Singleton; + +import org.apache.maven.execution.MavenSession; +import org.apache.maven.plugin.PluginValidationManager; +import org.apache.maven.plugin.descriptor.MojoDescriptor; +import org.codehaus.plexus.component.configurator.expression.ExpressionEvaluator; +import org.codehaus.plexus.configuration.PlexusConfiguration; + +/** + * Verify that plugin descriptor does not contain Plexus Component requirements. + */ +@Singleton +@Named +class PluginDescriptorRequirementsValidator implements MavenPluginConfigurationValidator { + + protected final PluginValidationManager pluginValidationManager; + + @Inject + PluginDescriptorRequirementsValidator(PluginValidationManager pluginValidationManager) { + this.pluginValidationManager = pluginValidationManager; + } + + @Override + public void validate( + MavenSession mavenSession, + MojoDescriptor mojoDescriptor, + Class<?> mojoClass, + PlexusConfiguration pomConfiguration, + ExpressionEvaluator expressionEvaluator) { + if (!mojoDescriptor.getRequirements().isEmpty()) { + pluginValidationManager.reportPluginMojoValidationIssue( + PluginValidationManager.IssueLocality.EXTERNAL, + mavenSession, + mojoDescriptor, + mojoClass, Review Comment: Two issues in this warning message: 1. **`{@code @Component}` is Javadoc syntax** — inside a Java string literal it will render literally as `{@code @Component}` in console output, not `@Component`. All other validators in this package (e.g. `PlexusContainerDefaultDependenciesValidator`, `Maven3CompatDependenciesValidator`) use plain text in their runtime messages. 2. **Grammar**: "Plugin use" should be "Plugin uses" (subject-verb agreement). The second clause is also awkward — "Maven 4 DI ... to inject dependencies should be used instead". Suggested rewrite: ```suggestion "Plugin uses Plexus Component requirements (@Component annotation). " + "Use Maven 4 Dependency Injection (for v4 plugins) or JSR 330 annotations (for v3 plugins) to inject dependencies instead."); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
