wilx opened a new pull request, #1345:
URL: https://github.com/apache/maven-assembly-plugin/pull/1345
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Your pull request should address just one issue, without pulling in
other changes.
- [x] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [ ] Each commit in the pull request should have a meaningful subject line
and body.
Note that commits might be squashed by a maintainer on merge.
- [x] Write unit tests that match behavioral changes, where the tests fail
if the changes to the runtime are not applied.
This may not always be possible but is a best-practice.
- [x] Run `mvn verify` to make sure basic checks pass.
A more thorough check will be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its
verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
## Summary
- Inject `org.codehaus.plexus.build.BuildContext` into the assembly archiver
and refresh the completed archive.
- Embed an m2e lifecycle mapping that ignores the `single` goal by default
during Eclipse workspace builds.
- Verify that archive creation refreshes the output path.
Fixes #1150
## Why
The plugin did not expose its generated archives through `BuildContext` and
did not provide m2e lifecycle metadata. As a result, m2e reported an
unsupported-goal marker for `assembly:single`, while explicitly enabled
executions could leave Eclipse unaware of the generated or updated archive.
The embedded `<ignore />` action provides a safe default: m2e runs the goal
during neither full nor incremental workspace builds. A project or parent POM
can still override this lower-priority plugin mapping with an m2e `<execute>`
or configurator action. When execution is enabled, the
`BuildContext.refresh(File)` call makes the result visible to the workspace.
The Codehaus `plexus-build-api` implementation is Sisu-indexed and retains
its legacy API bridge, so the same constructor injection also works in ordinary
Maven CLI builds.
## Validation
- Maven 3.9.16 / JDK 21: `mvn -Prun-its clean verify` — 268 unit tests and
all 150 integration tests passed.
- Maven 3.6.3 / JDK 8: `mvn -Denforcer.skip=true -Prun-its clean verify` —
268 unit tests and all 150 integration tests passed. The enforcer skip is
required because the current development parent requires Maven 3.9 to build.
- Maven 4.0.0-rc-5 / JDK 21: the focused `DefaultAssemblyArchiverTest` and
packaging passed. The full run passed all 268 unit tests and 144 of 150
integration tests; the remaining six existing fixtures fail during Maven 4
model construction with `The parents form a cycle`, before this plugin executes.
- `mvn -DskipTests package` packages the mapping at
`META-INF/m2e/lifecycle-mapping-metadata.xml`; XML validation and RAT pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
