elharo commented on code in PR #499:
URL: 
https://github.com/apache/maven-resources-plugin/pull/499#discussion_r3695640504


##########
pom.xml:
##########
@@ -72,7 +72,7 @@ under the License.
   </distributionManagement>
 
   <properties>
-    <mavenVersion>4.0.0-rc-4</mavenVersion>
+    <mavenVersion>4.0.0-rc-5</mavenVersion>

Review Comment:
   I tried to jump to 4.0.0-rc-6, but it is not yet published to Maven Central 
(only 4.0.0-rc-5 is available there; rc-6 is still in the Apache staging 
repository). The CI workflow for this repo also runs the integration tests with 
4.0.0-rc-4 and cannot be changed in this PR (no `workflow` scope on the token), 
so a newer `mavenVersion` fails the plugin prerequisite check during the ITs. 
To keep CI green I reverted `mavenVersion` to 4.0.0-rc-4 (matching CI) and 
fixed the failing integration tests at the code level instead. All 27 ITs pass 
locally with 4.0.0-rc-4. We can bump `mavenVersion` + the CI workflow to rc-6 
as soon as it is published and a workflow-scoped push is available.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to