wilx opened a new pull request, #294:
URL: https://github.com/apache/maven-dependency-analyzer/pull/294
## Summary
Avoid recommending `test` scope for a direct dependency when the same
artifact
is still required transitively on the compile or runtime dependency graph.
The analyzer now builds separate compile and runtime graphs without the
direct
test-only candidates and suppresses the warning for candidates that remain
reachable. This prevents an unsafe scope change: Maven conflict mediation can
otherwise hide the required transitive artifact behind the direct test-scoped
declaration.
Fixes apache/maven-dependency-plugin#1483
## Validation
- Maven 3.9.16 / JDK 21: `mvn -Prun-its verify`
- Maven 4 / JDK 21: `mvn clean -Prun-its verify`
- Maven 3.9.16 / JDK 8: 128 unit tests passed
- Maven Dependency Plugin downstream check: 415 unit tests passed; 102 of 103
Invoker projects passed. The remaining project asserts the previous scope
recommendation and passes with the unpatched analyzer. Its dependency graph
contains the exact condition fixed here: JUnit is also reachable through
`maven-project -> plexus-container-default`.
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Your pull request should address just one issue, without pulling in
other changes.
- [x] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
Note that commits might be squashed by a maintainer on merge.
- [x] Write unit tests that match behavioral changes, where the tests fail
if the changes to the runtime are not applied.
This may not always be possible but is a best-practice.
- [x] Run `mvn verify` to make sure basic checks pass.
A more thorough check will be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its
verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
