elharo opened a new issue, #276:
URL: https://github.com/apache/maven-remote-resources-plugin/issues/276
## Summary
`velocityFilterInMemoryThreshold` is declared with `@Deprecated` and the
javadoc says it is "not used anymore", yet it remains a configurable
`@Parameter` with a default of `5242880`.
`src/main/java/org/apache/maven/plugin/resources/remote/AbstractProcessRemoteResourcesMojo.java:252-262`
```java
/**
* When the result of velocity transformation fits in memory, it is compared
with the actual contents on disk
* to eliminate unnecessary destination file overwrite. This improves build
times ...
* @deprecated not used anymore
* @since 1.6
*/
@Deprecated
@Parameter(defaultValue = "5242880")
protected int velocityFilterInMemoryThreshold = 5 * 1024 * 1024;
```
No code reads this field; the velocity output always goes through
`CachingOutputStream`. Users may configure it expecting behavior changes and
get none.
## Suggested fix
Remove the parameter (and field) entirely, or rewire the
`CachingOutputStream` sizing to actually honor the threshold (with the
documented memory-comparison semantics), keeping the parameter non-deprecated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
