wilx opened a new pull request, #296:
URL: https://github.com/apache/maven-dependency-analyzer/pull/296
Fixes apache/maven-dependency-plugin#1345
## Summary
Preserve exact JVM binary class names when collecting dependency usages and
dependency artifact contents.
The analyzer previously assumed that every `$` in a binary class name
denoted an inner class and discarded or folded that name into its presumed
container. Kotlin can emit bytecode that references only a nested class, so the
corresponding artifact was incorrectly reported as unused. The assumption was
also invalid for legal top-level Java class names containing `$`.
Artifact lookup already deduplicates usages by artifact, so retaining the
exact binary name correctly handles both nested classes and top-level names
without independently inferring the source-level compilation unit.
The change adds:
- a Kotlin integration test reproducing the nested-class-only reference;
- an integration test for a genuine top-level Java class containing `$`;
- unit coverage for exact usage collection and exploded dependency
directories.
## Verification
- `mvn -Prun-its verify` with JDK 17: 128 unit tests and all 21 invoker
builds passed.
- Focused Kotlin and top-level-dollar integration tests passed with JDK 8
and JDK 17.
- The original Dropwizard/Kotlin reproducer completed without
dependency-analysis warnings.
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Your pull request should address just one issue, without pulling in
other changes.
- [x] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
Note that commits might be squashed by a maintainer on merge.
- [x] Write unit tests that match behavioral changes, where the tests fail
if the changes to the runtime are not applied.
This may not always be possible but is a best-practice.
- [x] Run `mvn verify` to make sure basic checks pass.
A more thorough check will be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its
verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
