wilx opened a new pull request, #12659:
URL: https://github.com/apache/maven/pull/12659
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Your pull request should address just one issue, without pulling in
other changes.
- [x] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
Note that commits might be squashed by a maintainer on merge.
- [x] Write unit tests that match behavioral changes, where the tests fail
if the changes to the runtime are not applied.
This may not always be possible but is a best-practice.
- [x] Run `mvn verify` to make sure basic checks pass.
A more thorough check will be performed on your pull request automatically.
- [x] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
## Description
Maven 3's `ReactorReader` returns the reactor project's build POM for every
artifact request whose extension is `pom`, before considering the classifier.
Consequently, resolving an attached classified POM from the reactor returns
`pom.xml` instead of the attached artifact.
This change limits the build-POM shortcut to unclassified POM requests.
Classified POMs proceed through the existing artifact-matching path, which
selects the attached artifact by extension and classifier. A focused unit test
reproduces the incorrect path before the fix and verifies the attached POM
afterward.
This is the Maven 3.10.x counterpart to apache/maven#12658.
Fixes apache/maven-dependency-plugin#1024
## Tests
- Regression test before the fix: expected `custom.pom`, but `ReactorReader`
returned `pom.xml`.
- Full root `mvn verify`: all 16 modules passed with RAT, Checkstyle,
Spotless, Animal Sniffer, and unit tests enabled.
- `maven-core`: 367 tests, 0 failures, 0 errors, 1 skipped.
- Complete unfiltered Maven 3.10.x Core IT suite with `run-its,embedded`:
all 78 modules passed; 867 tests, 0 failures, 0 errors, 39 skipped.
[core-its]: https://maven.apache.org/core-its/core-it-suite/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
