wilx opened a new pull request, #122:
URL: https://github.com/apache/maven-common-artifact-filters/pull/122
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Your pull request should address just one issue, without pulling in
other changes.
- [x] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
Note that commits might be squashed by a maintainer on merge.
- [x] Write unit tests that match behavioral changes, where the tests fail
if the changes to the runtime are not applied.
This may not always be possible but is a best-practice.
- [x] Run `mvn verify` to make sure basic checks pass.
A more thorough check will be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its
verify`).
This component has no `run-its` profile. The focused downstream Maven
Dependency Plugin MDEP-800 integration test passed against the patched
`3.4.1-SNAPSHOT`.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
## Summary
`ProjectTransitivityFilter` currently uses `Artifact.equals()` to identify
direct dependencies. Maven's legacy artifact equality compares the resolved
version, so a direct SNAPSHOT dependency can be rejected when one artifact
instance contains a timestamped version such as `1.0-20220318.120000-1` and the
other contains `1.0-SNAPSHOT`.
Compare `Artifact.getId()` instead. The ID retains group ID, artifact ID,
type, classifier, and base version, so timestamped and base SNAPSHOT
representations match without conflating different artifacts or base versions.
The regression test covers both accepting a timestamped resolution of a
direct SNAPSHOT and rejecting a genuinely different base version.
## Validation
- Maven 3.9.16 / Java 8: `clean verify` — 232 tests passed.
- Maven 3.9.16 / Java 21: `clean verify` — 232 tests passed.
- Maven 4.0.0-rc-5 / Java 21: `clean verify` — 232 tests passed.
- Maven Dependency Plugin: focused
`mdep-800-copy-dependencies-exclude-transitive-snapshot` IT passed against the
locally installed patched `3.4.1-SNAPSHOT`.
Fixes https://github.com/apache/maven-dependency-plugin/issues/1306
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
