desruisseaux commented on code in PR #328:
URL:
https://github.com/apache/maven-clean-plugin/pull/328#discussion_r3702564958
##########
src/main/java/org/apache/maven/plugins/clean/BackgroundCleaner.java:
##########
@@ -162,24 +235,22 @@ String fastDeleteError(IOException e) {
/**
* Deletes the specified directory and its contents in a background thread.
+ * This method is synchronized to support concurrent calls from parallel
module builds.
*
- * @param basedir the directory to delete, must not be {@code null}
+ * @param baseDir the directory to delete, must not be {@code null}
+ * @param force whether to force the deletion of read-only files
+ * @param retryOnError whether to undertake a batch retry of failed
deletions
* @return whether this method was able to register the background task
* @throws IOException if an error occurred while preparing the task
before execution in a background thread
*/
- @Override
- boolean fastDelete(Path baseDir) throws IOException {
+ synchronized boolean fastDelete(Path baseDir, boolean force, boolean
retryOnError) throws IOException {
Review Comment:
If this method does not override anymore a method of the parent class, try
to make this method private.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
