iarvind opened a new pull request, #2023:
URL: https://github.com/apache/maven-resolver/pull/2023
AWS S3 exposes user defined object metadata under the x-amz-meta- prefix, so
an object uploaded with the checksum-sha1 and checksum-md5 metadata keys is
served back with the x-amz-meta-checksum-sha1 and x-amz-meta-checksum-md5
response headers. XChecksumExtractor did not know about them, so Resolver fell
through to the Remote External strategy and issued a second request for the
checksum sidecar file, even though the checksum was already in hand from the
artifact response.
Teach the extractor that prefix. The three supported prefixes are now held
in a list and tried in order, keeping the pre-existing precedence: the first
prefix yielding any checksum wins, so a partial match on a later prefix cannot
leak into an earlier one's result.
Stores that follow the same metadata convention, such as Cloudflare R2,
MinIO and Backblaze B2, benefit from this as well.
Fixes #2019
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Your pull request should address just one issue, without pulling in
other changes.
- [ ] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [ ] Each commit in the pull request should have a meaningful subject line
and body.
Note that commits might be squashed by a maintainer on merge.
- [ ] Write unit tests that match behavioral changes, where the tests fail
if the changes to the runtime are not applied.
This may not always be possible but is a best-practice.
- [ ] Run `mvn verify` to make sure basic checks pass.
A more thorough check will be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its
verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
