wilx commented on code in PR #1341:
URL:
https://github.com/apache/maven-assembly-plugin/pull/1341#discussion_r3707832716
##########
src/it/projects/file-sets/multimodule-win-lineEndings/verify.groovy:
##########
@@ -17,36 +17,21 @@
* under the License.
*/
-File f = new File( basedir, "child/target/child-1-src/test.txt" );
+import java.nio.charset.StandardCharsets
+import java.nio.file.Files
-if ( !f.exists() )
+String expected = "1\r\nchild"
+for ( String name : [ "test.txt", "mac2win.txt" ] )
{
- System.out.println( "Filtered file from file-set: " + f + " is missing." );
- return false;
-}
-
-StringBuffer sb = new StringBuffer();
+ File file = new File( basedir, "child/target/child-1-src/" + name )
+ if ( !file.exists() )
+ {
+ throw new FileNotFoundException( "Filtered file from file-set: " +
file + " is missing." )
+ }
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
