slachiewicz opened a new pull request, #501:
URL: https://github.com/apache/maven-resources-plugin/pull/501
`siteMvn` is passed to `doCreateTask` whole, while `maven` is iterated:
```groovy
for (def mvn in mavens) { ... doCreateTask(os, jdk, mvn, ...) } //
maven: a List is correct
...
doCreateTask( os, jdk, siteMvn, tasks, first, 'site', taskContext ) //
siteMvn passed whole
```
and `doCreateTask` does `jenkinsEnv.mvnFromVersion(os, "${maven}")`. A
Groovy List stringifies to the literal `"[4.0.x]"`, which matches no `case` in
`mvnFromVersion` and falls through to `default: return 'maven_3_latest'`. It is
not null either, so the `mvnName == null` skip never fires — the site stage
just quietly runs Maven 3.
`maven: [ "4.0.x" ]` stays a List; only `siteMvn` needs to be a String.
apache/maven-deploy-plugin already does it this way.
Verified by reading the shared library, not by running a build — the
pipeline cannot be executed locally. It also does not make Jenkins green on its
own: `maven_4_latest` still resolves to 4.0.0-rc-5 on the build nodes. This
makes the configuration do what it already says.
Same fix as apache/maven-clean-plugin#331.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
