desruisseaux commented on code in PR #500:
URL:
https://github.com/apache/maven-resources-plugin/pull/500#discussion_r3712411021
##########
src/main/java/org/apache/maven/plugins/resources/TestResourcesMojo.java:
##########
@@ -62,7 +62,12 @@ public class TestResourcesMojo extends ResourcesMojo {
* {@inheritDoc}
*/
public void execute() throws MojoException {
- if (skip) {
+ // isSkip() reads ResourcesMojo's own field. Both classes declare a
private
+ // "skip", so the two collapse into a single descriptor parameter and
the
+ // configurator writes the superclass one, leaving this class's field
false
+ // however the build configured <skip>. Reading both is what makes
+ // <skip>true</skip> reach this goal at all.
+ if (skip || isSkip()) {
Review Comment:
This is a temporary workaround until
https://github.com/apache/maven/pull/12626 is available in a Maven release,
isn'it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
