kratos0718 commented on PR #317: URL: https://github.com/apache/maven-source-plugin/pull/317#issuecomment-5192118618
Both points addressed: the literal is inlined, and `AbstractSourceJarMojoTest` now covers which directories `createArchiver()` selects. The tests drive `createArchiver()` with a stubbed project and a mock `JarArchiver` and assert the file sets it receives — the exactly-named directory is added, a directory whose name merely ends with that text is not, and when both are present only the former is. I checked the last two against the previous `endsWith` version and both fail there, so they do pin the behaviour rather than just describing it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
