elharo commented on code in PR #112:
URL: https://github.com/apache/maven-shared-io/pull/112#discussion_r3720763444
##########
src/main/java/org/apache/maven/shared/io/download/DefaultDownloadManager.java:
##########
@@ -56,14 +57,49 @@ public class DefaultDownloadManager implements
DownloadManager {
private Map<String, File> cache = new ConcurrentHashMap<>();
+ /**
+ * Root directory for every download performed in this class loader. It is
created at most once
+ * and removed, with everything below it, by a single JVM shutdown hook.
+ * <p>
+ * This replaces {@link File#deleteOnExit()}, which added an entry to the
JVM-wide
Review Comment:
This describes the issue, not the code. Comments need to not reference past
code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
