elharo opened a new pull request, #175:
URL: https://github.com/apache/maven-resolver-ant-tasks/pull/175
Fixes #165
## Summary
`AntRepoSys.getProxySelector()` added every `<proxy>` entry from
`settings.xml` to the aether `DefaultProxySelector` without checking
`isActive()`. A proxy the user disabled with `<active>false</active>` therefore
still routed all artifact downloads. This matches Maven CLI behavior, which
selects the proxy via `settings.getActiveProxy()`.
## Changes
- `AntRepoSys.java`: add only `settings.getActiveProxy()` (the first proxy
with `isActive() == true`) to the proxy selector, instead of every proxy in
`settings.getProxies()`. No proxy is added when none is active.
- New unit test `ProxySelectorTest` covering:
- an inactive proxy declared before the active one is not applied
(previously the inactive proxy was selected),
- when only inactive proxies are declared, no proxy is applied.
## Verification
- New tests fail on master (inactive proxy is applied) and pass with the fix.
- `mvn verify` passes: all 56 tests succeed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
