elharo opened a new pull request, #176:
URL: https://github.com/apache/maven-resolver-ant-tasks/pull/176
Fixes #167
## Summary
`Settings.getGlobalFile()` delegated to `getRef().getFile()` instead of
`getRef().getGlobalFile()`, so a referenced `<settings refid="...">` returned
the referenced instance's user settings file when the global settings path was
requested. This silently lost global mirrors, proxies, and server configuration.
## Changes
- `types/Settings.java`: `getGlobalFile()` on a reference now delegates to
`getRef().getGlobalFile()`.
- New unit test `SettingsReferenceTest` covering:
- a referenced settings returns the referenced instance's global settings
file (previously the user settings file),
- the user settings file delegation keeps working.
## Verification
- New test fails on master (returns the user settings file) and passes with
the fix.
- `mvn verify` passes: all 56 tests succeed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
