goutamadwant opened a new pull request, #12703:
URL: https://github.com/apache/maven/pull/12703
Fixes #10377.
This fixes Maven 4.1.0 parent inference for reactor projects when parent
coordinates are partially omitted.
The file-to-raw model transformation now:
- infers a missing parent version from the matching reactor model before
raw-model validation;
- preserves the inferred version's source location.
Parent validation now checks whether `groupId` or `artifactId` was
explicitly declared before warning about combining coordinates with
`relativePath`. Values inferred from a relative parent POM no longer trigger
the warning.
The existing warning remains in place when a POM explicitly declares both a
non-empty `relativePath` and parent coordinates.
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Your pull request should address just one issue, without pulling in
other changes.
- [x] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
Note that commits might be squashed by a maintainer on merge.
- [x] Write unit tests that match behavioral changes, where the tests fail
if the changes to the runtime are not applied.
This may not always be possible but is a best-practice.
- [x] Run `mvn verify` to make sure basic checks pass.
A more thorough check will be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
### Tests
- `mvn verify`
- `MavenITmng8708ParentInferenceTest`: 2 tests passed
- `MavenITmng8708ParentInferenceTest,MavenITmng8294ParentChecksTest`: 8
tests passed
- `maven-impl`: 550 tests passed, 4 skipped
- Reporter reproduction: all three reactor projects build, and only the
explicitly combined parent declaration emits the warning
- `mvn -Prun-its verify`: source modules passed; the broad Core IT suite
reported two unrelated DI fixture errors because
`org.apache.maven:maven-testing:4.1.0-SNAPSHOT` was unavailable
- [x] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
