slachiewicz commented on issue #12704: URL: https://github.com/apache/maven/issues/12704#issuecomment-5225187899
Two existing issues ask for the same log line to be improved, from a different angle than this one. Recording them here so the wording is not changed twice in opposite directions: - #10800 ([MNG-8069](https://issues.apache.org/jira/browse/MNG-8069)) — the message is too unspecific; it should name the project that actually failed. PR #1435 implements that, still open, and it predates the module restructure so it patches `maven-embedder/.../cli/event/ExecutionEventLogger.java` rather than today's `impl/maven-cli/.../cling/event/ExecutionEventLogger.java`. - #10609 ([MNG-8155](https://issues.apache.org/jira/browse/MNG-8155)) — where the current wording came from, via #1599. Still open even though that PR is merged. Those two are about *naming* the culprit. This issue is about the sentence being false in the first place when nothing the project depends on failed. They compose: "X was not built because Y, which it depends on, failed to build" for the dependency case, and a separate sentence for the halted case. Also in the same area, for anyone triaging `BuildPlanExecutor`: #12585 and #12599 (concurrent writes to `MavenSession`, leaked thread pool) and PR #12680 (races in artifact resolution and phase ordering). None of them overlaps with the TEARDOWN outcome logic this issue is about. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
