slachiewicz opened a new pull request, #900:
URL: https://github.com/apache/maven-wagon/pull/900
Backport of #898 to `wagon-3.x`.
The six commits cherry-picked with one conflict, in
`wagon-providers/wagon-webdav-jackrabbit/pom.xml`: the branch carries
`jackrabbit-webdav` 2.20.16 with the "latest version compatible with Java 8"
comment rather than master's 2.20.17. Since the commit removes the dependency
outright, the resolution was to drop the whole block.
One further difference needed a decision. `wagon-3.x` guards the
`releaseConnection()` call in `doMkCol` with a null check that master does not
have:
```java
} finally {
if (method != null) {
method.releaseConnection();
}
}
```
The commit that replaces the Jackrabbit request classes moves the assignment
up to the declaration, so `method` can no longer be null and the guard becomes
dead. It is folded into that commit rather than left behind, which keeps the
two branches identical across every WebDAV source file — `git diff master` over
`wagon-webdav-jackrabbit/src/main/java` is now empty.
### Testing
`wagon-webdav-jackrabbit` on this branch: **295 tests, 0 failures**. The
branch point runs 283; the extra 12 are the `MultiStatusTest` cases the change
brings with it.
One caveat worth recording: on the first full-suite run
`WebDavsWagonTest.testWagonPutDirectoryWhenDirectoryAlreadyExists` failed with
a `TransferFailedException` against its localhost HTTPS port. It passed on the
next three runs in isolation and on a repeat of the full suite, and the branch
point behaves the same way, so it looks like a port or timing flake in the
HTTPS variant rather than anything this change introduces. Flagging it because
it will presumably surface in CI now and then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
